Skip to content

John6797/sc 8157/add genai description toggle as argument#303

Merged
johnwalz97 merged 3 commits intomainfrom
john6797/sc-8157/add-genai-description-toggle-as-argument
Jan 29, 2025
Merged

John6797/sc 8157/add genai description toggle as argument#303
johnwalz97 merged 3 commits intomainfrom
john6797/sc-8157/add-genai-description-toggle-as-argument

Conversation

@johnwalz97
Copy link
Contributor

@johnwalz97 johnwalz97 commented Jan 29, 2025

Internal Notes for Reviewers

Adding global toggle for turning on and off test description generation via the vm.init() function.

External Release Notes

@johnwalz97 johnwalz97 added enhancement New feature or request internal Not to be externalized in the release notes labels Jan 29, 2025
@johnwalz97 johnwalz97 requested a review from cachafla January 29, 2025 16:34
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces several enhancements and changes to the project:

  1. Dependency Updates:

    • Added anywidget version 0.9.13 as a new dependency in pyproject.toml.
    • Added psygnal version 0.11.1 as a new dependency in poetry.lock.
    • Updated the docutils package to include specific Python version constraints and file hashes.
  2. Version Update:

    • Updated the project version from 2.8.3 to 2.8.4.
  3. Environment Variable Handling:

    • Modified the logic for checking the VALIDMIND_LLM_DESCRIPTIONS_ENABLED environment variable to ensure it is case-insensitive.
    • Introduced a new optional parameter generate_descriptions in the init function of validmind/api_client.py to control the environment variable VALIDMIND_LLM_DESCRIPTIONS_ENABLED.
  4. Configuration Checks:

    • Replaced the client_config.can_generate_llm_test_descriptions() check with is_configured() in validmind/tests/model_validation/ragas/utils.py and validmind/tests/prompt_validation/ai_powered_test.py to ensure proper configuration before proceeding with LLM-based operations.

These changes aim to improve the flexibility and configurability of the LLM features and ensure that the necessary dependencies are correctly managed.

Test Suggestions

  • Verify that the anywidget and psygnal packages are correctly installed and imported in the project.
  • Test the init function with different values for generate_descriptions to ensure the environment variable is set correctly.
  • Check that the LLM configuration logic using is_configured() works as expected in various scenarios, such as missing API keys or disabled features.
  • Ensure that the updated version number is reflected in all relevant parts of the application.
  • Run integration tests to confirm that the new dependencies do not introduce any conflicts or issues.

Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@johnwalz97 johnwalz97 merged commit 6dfc703 into main Jan 29, 2025
9 checks passed
@johnwalz97 johnwalz97 deleted the john6797/sc-8157/add-genai-description-toggle-as-argument branch January 29, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants